Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add req,res type #31

Merged
merged 4 commits into from
Sep 13, 2023
Merged

refactor: add req,res type #31

merged 4 commits into from
Sep 13, 2023

Conversation

akastercomcom
Copy link
Collaborator

@akastercomcom akastercomcom commented Sep 12, 2023 •
edited
Loading

reqeust type과
response type을 만들었습니다.

yoojinko
yoojinko approved these changes Sep 13, 2023
View reviewed changes
Copy link
Collaborator

@yoojinko yoojinko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some minor comments. Thanks

src/types/type.ts Outdated
appName: string,
};

export type response = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor)

export type response = request & {
  responseData: string,
  status: RESPONSE_STATUS,
  amount: number,
};

로 연관성을 명확하게 표기 가능할 것 같습니다.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor) amount 대신 cost 어떠신가요.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

반영했습니다.

@akastercomcom
Copy link
Collaborator Author

Thanks for review
now merged!

@akastercomcom akastercomcom merged commit 17dafe2 into develop Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoojinko yoojinko yoojinko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akastercomcom @yoojinko